Install playerctl alongside voxtype so pause_media actually works - #9244
Open
montanasnow wants to merge 1 commit into
Open
Install playerctl alongside voxtype so pause_media actually works#9244montanasnow wants to merge 1 commit into
montanasnow wants to merge 1 commit into
Conversation
The shipped default config.toml turns on pause_media = true, but Voxtype shells out to playerctl to pause MPRIS players and the installer never pulled it in, so the feature silently no-oped (confirmed via journalctl: "playerctl not found or failed to run"). Fixes omacom#9243
|
One leftover: existing Voxtype installs do not get the package until they re-run the installer. |
|
Follow-up for existing Voxtype installs: #9329 — same installer line as this PR, plus a migration that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default/voxtype/config.tomlshipspause_media = trueby default, but Voxtype implements that by shelling out toplayerctl, andomarchy-voxtype-installnever installed it — so the feature silently failed on every fresh install.journalctl --user -u voxtype:WARN playerctl not found or failed to run: No such file or directory (os error 2).playerctlto theomarchy-pkg-addcall inbin/omarchy-voxtype-install.Test plan
./test/all— same 5 pre-existing failures as onquattrobefore this change (all unrelated: missingomarchy-pkgscheckout / snapper / theme-install-guards / unowned-system-paths / windows-vm-mount-boundary), none touching voxtypeplayerctland confirmed dictation now pauses a Chromium tab's MPRIS player (Google Music) and resumes it afterFixes #9243